fix(builtin): fix a bug where mjs entry points were not added to runfiles #3406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
approved these changes
Apr 13, 2022
internal/node/node.bzl
Outdated
| # entry point is only needed in runfiles if it is a .js file | ||
| if len(ctx.files.entry_point) == 1 and ctx.files.entry_point[0].extension == "js": | ||
| # entry point is only needed in runfiles if it is a javascript file | ||
| if len(ctx.files.entry_point) == 1 and ctx.files.entry_point[0].extension in ["js", "mjs"]: |
There was a problem hiding this comment.
nit: maybe we could share a constant list with some other location like is_js_file helper or something? it feels always hard to know all the spots that need updates
| @@ -3,14 +3,12 @@ load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary") | |||
| nodejs_binary( | |||
| name = "has_deps", | |||
| data = [ | |||
There was a problem hiding this comment.
ah, this should have been our clue
alexeagle
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: Generally related to #3277
Calling
bazel runon anodejs_binarytarget that doesn't add its entry_point todatawill cause node to run with no script.What is the new behavior?
The script is run properly.
Does this PR introduce a breaking change?